chore: Use simple_x509 to generate webrtc self-signed cert #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
rcgen
usingring
rng when signing the certificate and the lack of an API to seed the rng, we are not able to properly generate deterministic certificates utilizingring
. Originally, exposing the api to generate the certificate by the end-user so they could eventually pass that same certificate back internally was the idea to get around this, however this may not be a preferred option long term since this requires the node to store the certificate and keypair generated.This PR introduce a change to use
simple_x509
to generate the certificate instead ofrcgen
, which would allow us to use the ecdsa keypair to sign the certificate instead, which would allow us to produce a deterministic certificate.Relates to libp2p/rust-libp2p#3049
Note: