[WIP] Add support for TTL and time/interval formats in actor timers/reminders #652 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Giovds
force-pushed
the
issue-652-add-ttl-for-timers-and-reminders
branch
from
8d55d05
to
2285239
Compare
|
@Giovds Is there any progress in this? |
|
@mukundansundar I haven't had the time to finish this yet, and I will still be unavailable next week. I expect to have time again afterwards. I think what is left is to write integration tests to prove that it works, but I couldn't get them to run them locally yet. |
Giovds
force-pushed
the
issue-652-add-ttl-for-timers-and-reminders
branch
from
e63203d
to
76945aa
Compare
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
There is no need to create an instance of the DurationUtils or to extend it. Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Since the class is package-private there is no need to make the getters public. Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Signed-off-by: Giovanni van der Schelde <[email protected]>
Giovds
force-pushed
the
issue-652-add-ttl-for-timers-and-reminders
branch
from
76945aa
to
3f6b554
Compare
|
@Giovds nudge - is there any update on this PR ? |
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
============================================
+ Coverage 77.62% 78.09% +0.47%
- Complexity 993 1028 +35
============================================
Files 91 92 +1
Lines 3128 3196 +68
Branches 342 349 +7
============================================
+ Hits 2428 2496 +68
- Misses 534 535 +1
+ Partials 166 165 -1
Continue to review full report at Codecov.
|
@mukundansundar #652 (comment) Mainly stuck at creating integration tests and running them locally. |
|
gentle ping - @Giovds. Please see README as to how to run the tests locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should add the following items:
ActorTimers
ActorReminders
Integration test
Issue reference
The issue this PR will close: #652
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: