Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update batcher signature so my contrib pr is happy in ci #7715

Closed
wants to merge 1 commit into from

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented May 3, 2024

Description

context: dapr/components-contrib#3410

I'm dealing with incompatible func signatures between dapr and kit causing my contrib pr ci runs to fail when bumping cert test dependencies...

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@sicoyle sicoyle requested review from a team as code owners May 3, 2024 21:40
@artursouza
Copy link
Member

Build is failing. Does it need kit to be updated here too?

@sicoyle
Copy link
Contributor Author

sicoyle commented May 14, 2024

I think this can be closed. Josh worked some magic in my PR where I thought I needed this:
dapr/components-contrib#3324

@sicoyle sicoyle closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants