New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Tests: adds runtime version skew tests #7575
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7575 +/- ##
==========================================
+ Coverage 61.39% 61.81% +0.41%
==========================================
Files 265 245 -20
Lines 22609 22420 -189
==========================================
- Hits 13880 13858 -22
+ Misses 7579 7398 -181
- Partials 1150 1164 +14 ☔ View full report in Codecov by Sentry. |
s.daprd2 = daprd.New(t, | ||
daprd.WithAppProtocol("grpc"), | ||
daprd.WithAppPort(srv2.Port(t)), | ||
daprd.WithExecOptions(exec.WithVersion(t, "1.13")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal for your skew test PR to eventually write all future version skew tests, and keep adding those files in this manner? Or just for one off testing people can update these values?
Im wondering if the version should be parameterized here or if we should make this file name indicative that its for 1.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the idea is that we would keep adding to these tests as and when. We can create things like previous
enums if we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be really nice to use for future versions. Thanks Josh 🚀
Nice addition Josh. Is there a way where we need not repeatedly add the main.go for each future version? Can we have |
There is no great workaround here as the |
Adds v1.13 binary building for integration tests. Integration test cases can now execute tests with v1.13 runtime binaries, making it possible to assert version skew scenarios in custom cases. As we release new versions, we can add to this list of binaries to support version skew testing. By default, current tree code binaries will continue to be used. Signed-off-by: joshvanl <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Josh van Leeuwen <[email protected]>
Signed-off-by: joshvanl <[email protected]>
036ec45
to
1a256bd
Compare
Signed-off-by: joshvanl <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7575 +/- ##
==========================================
+ Coverage 61.39% 61.81% +0.41%
==========================================
Files 265 245 -20
Lines 22609 22420 -189
==========================================
- Hits 13880 13858 -22
+ Misses 7579 7398 -181
- Partials 1150 1164 +14 ☔ View full report in Codecov by Sentry. |
Adds v1.13 binary building for integration tests. Integration test cases can now execute tests with v1.13 runtime binaries, making it possible to assert version skew scenarios in custom cases.
As we release new versions, we can add to this list of binaries to support version skew testing. By default, current tree code binaries will continue to be used.