Test Integration: Hot Reload spec.ignoreErrors
#7514
+292
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7514 +/- ##
==========================================
- Coverage 61.39% 61.35% -0.04%
==========================================
Files 265 265
Lines 22609 22609
==========================================
- Hits 13880 13872 -8
- Misses 7579 7586 +7
- Partials 1150 1151 +1 ☔ View full report in Codecov by Sentry. |
JoshVanL
added
the
autoupdate
cicoyle
previously approved these changes
Feb 26, 2024
JoshVanL
force-pushed
the
int-test-hotreload-ignoreErrors
branch
2 times, most recently
from
637d323
to
826caa7
Compare
artursouza
previously approved these changes
Mar 26, 2024
artursouza
added
the
automerge
Adds integration tests that assert that the `spec.ignoreErrors` field works as expected when hot reloading a component, namely that daprd exits error when `spec.ignoreErrors=false` and continues running when `spec.ignoreErrors=true`. No implementation changes. Signed-off-by: joshvanl <[email protected]>
JoshVanL
force-pushed
the
int-test-hotreload-ignoreErrors
branch
from
0073a46
to
2cadd07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests that assert that the
spec.ignoreErrorsfield is respected when hot reloading a component. Namely that daprd exits error whenspec.ignoreErrors=false, and continues running whenspec.ignoreErrors=true.No implementation changes.