Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify dnsPolicy in sidecar injector helm chart #7407

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

whytem
Copy link

@whytem whytem commented Jan 18, 2024

Description

When enabling hostNetwork: true in the sidecar injector chart to resolve networking issues associated with using CNI on EKS, which results in the Kubernetes Control Plane being unable to access the sidecar injector webhook, it is often also necessary to set the pod's dnsPolicy to 'ClusterFirstWithHostNet' to prevent DNS issues.

The sidecar injector Helm Chart currently offers no ability to specify the dnsPolicy and hence it always reverts to the cluster default.

This straightforward PR adds the option to provide this value to the sidecar injector chart. If no value is explicitly specified, it continues using the cluster default per the existing behavior.

Issue reference

#4270

Checklist

@whytem whytem requested review from a team as code owners January 18, 2024 16:27
@yaron2
Copy link
Member

yaron2 commented Jan 20, 2024

Thanks for this contribution. Can you please add this option to the table here? https://github.com/dapr/dapr/tree/master/charts/dapr

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.31%. Comparing base (9f5a423) to head (6bfae86).
Report is 115 commits behind head on master.

❗ Current head 6bfae86 differs from pull request most recent head ab758ff. Consider uploading reports for the commit ab758ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7407      +/-   ##
==========================================
+ Coverage   62.26%   62.31%   +0.04%     
==========================================
  Files         245      240       -5     
  Lines       22380    22058     -322     
==========================================
- Hits        13935    13745     -190     
+ Misses       7289     7172     -117     
+ Partials     1156     1141      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whytem
Copy link
Author

whytem commented Jan 20, 2024

Sure. I've added an explanation of the new configuration option in the readme. Thanks

@daixiang0
Copy link
Member

@whytem please fix DCO.

@whytem whytem force-pushed the master branch 5 times, most recently from 7746f5a to 93c14f4 Compare January 22, 2024 02:56
… is generally required when utilizing hostNetwork=true which is generally not cluster default

Signed-off-by: Michael Whyte <[email protected]>
@whytem
Copy link
Author

whytem commented Jan 22, 2024

@daixiang0 Fixed! Thank you

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale Issues and PRs without response and removed stale Issues and PRs without response labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants