Skip to content

Aio pika ack request early #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d7529ae
Merge pull request #1 from dapper91/dev
dapper91 Nov 9, 2019
9479fbe
Merge pull request #3 from dapper91/dev
dapper91 Nov 9, 2019
f802125
Merge pull request #5 from dapper91/dev
dapper91 Nov 10, 2019
ea59b1f
Merge pull request #6 from dapper91/dev
dapper91 Nov 16, 2019
ad307d6
Merge pull request #7 from dapper91/dev
dapper91 Dec 9, 2019
9a0de86
Merge pull request #8 from dapper91/dev
dapper91 Mar 14, 2020
1e83836
Merge pull request #11 from dapper91/dev
dapper91 Mar 28, 2020
0116e96
Merge pull request #13 from dapper91/dev
dapper91 Oct 25, 2020
480bc4e
Merge pull request #19 from dapper91/dev
dapper91 Mar 2, 2021
6fd3da3
Merge pull request #20 from dapper91/dev
dapper91 Mar 2, 2021
048938d
Merge pull request #25 from dapper91/dev
dapper91 Jul 28, 2021
d0e7504
Merge pull request #27 from dapper91/dev
dapper91 Aug 10, 2021
464018d
Merge pull request #29 from dapper91/dev
dapper91 Aug 15, 2021
4c744e1
Merge pull request #35 from dapper91/dev
dapper91 Aug 24, 2021
b2fc556
Merge pull request #39 from dapper91/dev
dapper91 Sep 1, 2021
7912204
Merge pull request #41 from dapper91/dev
dapper91 Sep 10, 2021
cbf5c9e
Merge pull request #43 from dapper91/dev
dapper91 Sep 10, 2021
bd63b72
Merge pull request #46 from dapper91/dev
dapper91 Nov 3, 2021
d7efb06
Merge pull request #48 from dapper91/dev
dapper91 Nov 3, 2021
0b0d9c7
Merge pull request #55 from dapper91/dev
dapper91 Nov 30, 2021
74455c7
Merge pull request #57 from dapper91/dev
dapper91 Mar 6, 2022
dc5cb36
Merge pull request #69 from dapper91/dev
dapper91 May 22, 2022
27a9630
Merge pull request #85 from dapper91/dev
dapper91 Jul 5, 2022
ddd90ba
Merge pull request #94 from dapper91/dev
dapper91 Aug 10, 2023
21edb43
Merge pull request #96 from dapper91/dev
dapper91 Sep 26, 2023
d404454
Merge pull request #98 from dapper91/dev
dapper91 Nov 28, 2023
0a3300a
Merge pull request #100 from dapper91/dev
dapper91 Dec 7, 2023
badd7eb
Merge pull request #102 from dapper91/dev
dapper91 Dec 15, 2023
d4ad929
Merge pull request #105 from dapper91/dev
dapper91 Apr 21, 2024
82a3e4a
Ensure bad rpc methods won't be reissued
Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pjrpc/server/integration/aio_pika.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ async def _rpc_handle(self, message: aio_pika.abc.AbstractIncomingMessage) -> No
"""

try:
# Acknowledge message early. This ensures, that a bad implemented rpc method
# which causes a appliaction crash won't be reissued again after restart
await message.ack()

reply_to = message.reply_to
response_text = await self._dispatcher.dispatch(message.body.decode(), context=message)

Expand Down
Loading