fix: Handle valid date provided as string #224 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common use-case to provide date as a valid string. Even the backend responses come as a plain string which represents the date.
rahuldimri
added a commit
to rahuldimri/ngx-pipes
that referenced
this pull request
Jun 14, 2022
|
@danrevah Can you please have a look into this. |
|
@shaungrady @tiger-seo @felladrin @spyr0s Can you please review this request. Its been more than a month. |
|
Sorry, @rahuldimri, but it seems @danrevah is the only one with write access to this repository. So you'll need to wait for their review. |
|
@felladrin sure thanks !! |
|
@danrevah Any idea when we are going to merge this change. |
|
@danrevah any idea when are you going to merge this request. |
|
@danrevah Ping. Maybe you can give write access to other main contributors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common use-case to provide date as a valid string. Even the backend responses come as a plain string which represents the date.