-
Notifications
You must be signed in to change notification settings - Fork 224
Added Google GenAI Embeddings #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
the new |
This will only work with an API key and not via Vertex API, correct? Would be really nice to have this for Vertex as well. |
@Dual-0 setting the environment variable |
@falkenbt yes this works with Google GenAI, I can add VertexAI support in Subsequent PRs |
wow that was fast, thank you! |
with
or
only with
I will wait for merge... |
Thank you for the PR, please address merge conflicts. |
@@ -26,6 +26,7 @@ class EmbeddingsProvider(Enum): | |||
HUGGINGFACETEI = "huggingfacetei" | |||
OLLAMA = "ollama" | |||
BEDROCK = "bedrock" | |||
GOOGLE_GENAI = "google_genai" | |||
GOOGLE_VERTEXAI = "vertexai" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danny-avila should I rename this to make the naming consistent, similar to google_genai
?
GOOGLE_VERTEXAI = "vertexai" | |
GOOGLE_VERTEXAI = "google_vertexai" |
@danny-avila thanks for merging the previous PR, I've resolved the conflict here: c2ca282 |
Added Google GenAI Embeddings