fix+feat: fix infinte-loading due to non-call of callback and expose error message into frontend

[ilsubyeega]

Summary

When a new user tried to sign up with social login, while registration disabled, the callback won't being called and would have to wait for a long time due to no callbacks. Also This PR also introduces append error parameter to /login frontend route to show the error of oauth.

• Backend

  • return callback if registration has been closed.
  • Wrap passport.authenticate to handle the error message and then redirect into.
  • Expose error message by redirecting to /login?error=<MESSAGE>.

• Frontend

  • Login.tsx: Extract ?error parameters from the URL and show it as an error message.
    • created customError state since error state always localized.
    • duplicated error element for customError usage.

• Concerns

  • customError state is duplicated with error state. And might need to change names to avoid confusion.

Since I'm not used on express.js and React, Please let me know if i wrong of this

Change Type

Please delete any irrelevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Translation update
• Documentation update

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

I have no idea which unit test should i create.

Tested with ALLOW_SOCIAL_LOGIN=true and ALLOW_SOCIAL_REGISTRATION=false env.

Checklist

Please delete any irrelevant options.

• My code adheres to this project's style guidelines
• I have performed a self-review of my own code
• I have commented in any complex areas of my code
• I have made pertinent documentation changes
• My changes do not introduce new warnings
• I have written tests demonstrating that my changes are effective or that my feature works
• Local unit tests pass with my changes
• Any changes dependent on mine have been merged and published in downstream modules.

[danny-avila]

thanks! looks great, will test it and merge by end of weekend

[danny-avila]

It does work as expected when social registration is disabled and attempting to use a new account. However, the issue exists when using an existing account.