Fix string comparison in object type filter #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object type filter used strncmp() to compare object type names, but limited the comparison to the length of the filter string. For example, a filter of 'GstPad' would display both 'GstPad' and 'GstPadTemplate' types. Use g_strcmp0() instead, it uses the entirety of both strings when comparing.
|
Hi @bshankstd, that was intentional to be able to match all objects of a given group. There's a TODO written somewhere to replace the filter with a globbing function or regular expression, that I never got around to implementing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object type filter used strncmp() to compare object
type names, but limited the comparison to the length of the
filter string. For example, a filter of 'GstPad' would display
both 'GstPad' and 'GstPadTemplate' types.
Use g_strcmp0() instead, it uses the entirety of both strings
when comparing.