fix #13968: Addon execution fails for some paths with spaces on Windows #7632
Conversation
ludviggunne
force-pushed
the
13968
branch
2 times, most recently
from
205ad6f to
8ecd18f
Compare
| ec = 1 if os.name == 'nt' else 127 | ||
|
|
||
| # Make sure the full command is used | ||
| assert 'The system cannot find the path specified. [internalError]' in stderr |
There was a problem hiding this comment.
I don't really understand this test.
There was a problem hiding this comment.
Without the fix, the error is similar to the one in the ticket, i.e. the part before the whitespace is interpreted as a command, and the rest of the path it's argument(s).
|
|
||
| #ifdef _WIN32 | ||
| cmd = "\"" + cmd + "\""; |
There was a problem hiding this comment.
spontanously this looks wrong to me. If cmd is:
"C:\Program Files\Cppcheck Premium\premiumaddon.exe" --cli foo.c.dump
then here it is changed to:
""C:\Program Files\Cppcheck Premium\premiumaddon.exe" --cli foo.c.dump"
so if the initial "" are removed then that is:
C:\Program Files\Cppcheck Premium\premiumaddon.exe" --cli foo.c.dump"
Is this intended behavior?
There was a problem hiding this comment.
In what situation would the "" be removed?
There was a problem hiding this comment.
hmm.. I believe that "" means nothing in the command processor?
I assume that a command ""C:\Program Files\Cppcheck Premium\premiumaddon.exe" --cli foo.c.dump" would fail if I execute it in a windows command terminal.
There was a problem hiding this comment.
The Windows command line seems to parse quotations differently: https://stackoverflow.com/a/6378038
No description provided.