cfg/qt.cfg - Change the Q_D definition to avoid false positives #7629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Qt macros Q_DECL_DEPRECATED and Q_DECL_DEPRECATED_X for people use the Qt library.
Change the O_D macro definition by moving the 'const' qualifier to the front of the statement. Without this change we get false positives "style: Variable 'd' can be declared as pointer to const [constVariablePointer]" The current definition follows Qt correctly as we see this define in the `QtCore/qtclasshelpermacros.h` file: Q_D(Class) Class##Private * const d = d_func() but apparently cppcheck doesn't properly recognize that as a const variable pointer.
|
Can you add a test in |
|
yes, I can add a test. however, I think a larger problem is that cppcheck seems to not like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the O_D macro definition by moving the 'const' qualifier
to the front of the statement.
Without this change we get false positives "style: Variable 'd' can be
declared as pointer to const [constVariablePointer]"
The current definition follows Qt correctly as we see this
define in the
QtCore/qtclasshelpermacros.hfile:#define Q_D(Class) Class##Private * const d = d_func()
but apparently cppcheck doesn't properly recognize that
as a const variable pointer.