Fix BOOST_REQUIRE false positives #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaslutsch
changed the title
The REQUIRE macros would not exit early and in case a null pointer would be in the condition it would not get caught and this would show false positives in next usages of the condition and show a nullPointerOutOfMemory warning.
andreaslutsch
force-pushed
the
fix_boost_require_false_positives
branch
from
1b7c722 to
2a227df
Compare
|
Thanks for your contribution. How would you like to be credited as an author? |
Hi, I guess just my name would be fine as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BOOST_REQUIRE macros would not exit early and in case of a possible null pointer assignment in the condition, it would not get caught in the macro definition.
This would show false positives in next usages of the condition and show a
nullPointerOutOfMemorywarning, whereas the BOOST_REQUIRE would have thrown an exception.Mimic BOOST_REQUIRE behavior in the macro.
Added a test for this, also the warning would not show when using
std::malloc, but does show up when usingmalloc.