Fix 12372: C++20: syntaxError with implicit operator and requires clause #6397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (tok = tok->next(); tok && !Token::Match(tok, ";|{"); tok = tok->next()) { | ||
| if (tok->link() && Token::Match(tok, "<|[|(")) | ||
| tok = tok->link(); | ||
| if (Token::simpleMatch(tok, "bool {")) |
There was a problem hiding this comment.
Should this be "%bool% {"? But apparently it's not needed at all...
There was a problem hiding this comment.
No, this is for checking when doing explicit conversion to bool as the requires clause doesnt allow implicit conversion to bool so then the user will need to explicitly convert with either static_cast<bool>(...), (bool) ..., bool(...) or bool{...}. However, the latter(ie bool{}) will exit the loop on { so this extra check is there to continue with the explicit conversion.
There was a problem hiding this comment.
If it is needed for something, we should have a test for that.
|
@chrchr-github @danmar Any more feedback? |
danmar
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.