Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidated ValueFlow tuning options into ValueFlowOptions #6332

Merged
merged 4 commits into from
May 21, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave changed the title added ValueFlowOptions consolidated ValueFlow tuning options into ValueFlowOptions Apr 23, 2024
@firewave firewave force-pushed the vfopts branch 4 times, most recently from da942ae to 28a08c8 Compare May 1, 2024 09:45
@firewave
Copy link
Collaborator Author

firewave commented May 6, 2024

I will pull out the global switch for the ValueFlow to a separate PR as it causes a behavior change (albeit only for the CI and my testing).

The bailout messages will also be done in a follow up as they might have ripple effects.

@firewave firewave marked this pull request as ready for review May 6, 2024 12:12
@firewave
Copy link
Collaborator Author

firewave commented May 6, 2024

Please point out any additional thresholds I might have missed.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I just have a small nit. Feel free to merge.

lib/valueflow.cpp Outdated Show resolved Hide resolved
@firewave firewave merged commit 9990975 into danmar:main May 21, 2024
63 checks passed
@firewave firewave deleted the vfopts branch May 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants