fix: JSX namespace usage without import #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Merged
1 task
|
Please rebase your branch and leave a valid reason why this change is necessary |
|
In this libs built files, the output, the JSX namespace is used, without being imported, this doesn't work in all envs, specifically latest TS + React, I propose using ReactElement imported directly from React, which fixes the issue but makes absolutely no functional difference |
martinnaj
force-pushed
the
fix/jsx-not-defined
branch
from
1c84322 to
48660dd
Compare
martinnaj
force-pushed
the
fix/jsx-not-defined
branch
from
48660dd to
884bbd1
Compare
|
@danilowoz All done, please review and merge asap |
|
@danilowoz Valid reason was given in the issue #333 and in this PR |
|
🎉 This PR is included in version 7.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this section, you should give the overview of the problem and the proposed changes.
A JSX reference is present, without the necessary import (necessary in latest react + ts)
Related Issue #[issue number]
If this PR is fixing any issue, then please include - Related Issue #[issue number]
#333
Any Breaking Changes
If this PR is introducing any breaking changes then mention them in this section.
Checklist