fix: Hide "Remember me" checkbox when needed #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
fix/hide-remember-when-needed
branch
from
6959662 to
5937202
Compare
mvandenburgh
changed the title
|
Thank you Mike. Released as 1.5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
django-allauth-uiassumes that therememberBooleanFieldalways exists on theLoginForm. However, when using the defaultdjango-allauthLoginForm, therememberfield is not present when theACCOUNT_SESSION_REMEMBERsetting is set. See https://github.com/pennersr/django-allauth/blob/main/allauth/account/forms.py#L129-L130. When that setting is set, the "Remember me" label text still appears on thedjango-allauth-uilogin page.Screenshot from the
django-allauth-uisample project, with theACCOUNT_SESSION_REMEMBERset toTrue(notice there is no checkbox next to "Remember me"):This pull request conditionalizes the
rememberfield in the login template to only render whenLoginForm.rememberexists.