Persistent go-ios agent after the initial go-ios terminates. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stoktamisoglu
force-pushed
the
persistent_tunnel
branch
from
83ae814 to
09fd243
Compare
|
Hi @dmissmann and @danielpaulus , would you review the #560 at your conveniences? |
dmissmann
approved these changes
Feb 11, 2025
Thanks for the review @dmissmann. Formal and graceful way to terminate the tunnel is still Of course, kill and and the signals are still alternative to stop the tunnel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When go-ios is started in agent mode, the agent terminates when the parent go-ios process terminates. If you run go-ios in multiple terminal for multiple device test automation the this can disrupt other terminal sessions which may be using the first started tunnel.
With this PR we use SysProcAttr for *nix and Window platforms.
For *nix platforms setting Setsid: true starts agent in an independent new *nix session. And for windows as this setting is not available by OS nature we can use CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP to start the process in a new process group.
They are tested on *nix and Windows and works well.