Add id for better result ranking, see #1

danielbayerlein · Mar 20, 2017 · 93b11fe · 93b11fe · bayleedev · Mar 20, 2017
1 parent 80d668a
commit 93b11fe
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/__tests__/github.js b/__tests__/github.js
@@ -12,6 +12,7 @@ describe('github.js', () => {
     let cache;
 
     const mockResult = require('../__mocks__/result.json').items.map(repository => ({
+      id: repository.full_name,
       title: repository.full_name,
       value: repository.html_url,
       subtitle: repository.description,
@@ -58,6 +59,13 @@ describe('github.js', () => {
         })
       ));
 
+    test('returns the expected id', () => (
+      github.search('honeycomb')
+        .then((repositories) => {
+          expect(repositories[0].id).toBe('altamiracorp/honeycomb');
+        })
+      ));
+
     test('returns the expected title', () => (
       github.search('honeycomb')
         .then((repositories) => {
@@ -170,6 +178,12 @@ describe('github.js', () => {
       })
     ));
 
+    test('returns an object with a id', () => (
+      searchResult.then((repositories) => {
+        expect(repositories[0].id).toBeDefined();
+      })
+    ));
+
     test('returns an object with a title', () => (
       searchResult.then((repositories) => {
         expect(repositories[0].title).toBeDefined();

diff --git a/src/github.js b/src/github.js
@@ -41,6 +41,7 @@ module.exports.search = (query) => {
     got(URL, options)
       .then((response) => {
         const data = response.body.items.map(repository => ({
+          id: repository.full_name,
           title: repository.full_name,
           value: repository.html_url,
           subtitle: repository.description,