Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade octokit/rest.js for CVE patch #1477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chris-griffin
Copy link

Just some cleanup for a transitive CVE: GHSA-h5c3-5r3r-rr8q

None of these breaking changes should impact v12 of danger-js as it requires node >= 18.


- v19 dropped support for node 10/12 (https://github.com/octokit/rest.js/releases/tag/v19.0.0)
- v20 dropped support for node 14/16, removed preview support for the REST API, and removed the agent option (https://github.com/octokit/rest.js/releases/tag/v20.0.0)
- v21 updated the package to ESM (https://github.com/octokit/rest.js/releases/tag/v21.0.0)

None of these breaking changes should impact v12 of danger-js as it requires node >= 18.
@mrginglymus
Copy link

danger-js also pulls in memfs-or-file-map-to-github-branch, which still relies on the old version of @octokit/rest:

https://github.com/orta/memfs-or-file-map-to-github-branch/blob/c293897e6b7cf80b23f16956ee2dc236953323e7/package.json#L19

This package will need updating in order to prevent danger-js pulling in the CVE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants