-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Content-Type when uploading certain Zarr entries #1576
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1576 +/- ##
==========================================
+ Coverage 88.53% 88.66% +0.13%
==========================================
Files 78 78
Lines 10829 10855 +26
==========================================
+ Hits 9587 9625 +38
+ Misses 1242 1230 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
given the discussion in dandi-archive PR, could you please just try uploading some zarr to dandi-staging e.g. to https://gui-staging.dandiarchive.org/dandiset/214256 and see if resultant downloads have correct content encoding and rendered by browser if you visit those urls |
@yarikoptic I uploaded a Zarr to that Dandiset, with Content-Type set in the PUT request, and downloading its
What URL? If you mean via dandidav, it doesn't cover staging. |
pretty much this URL on S3 for the asset you tried: https://dandi-api-staging-dandisets.s3.amazonaws.com/zarr/8c9d4d53-4084-4fc5-9720-0c809a5903ef/.zarray and it is all good! It is different from e.g. https://dandi-api-staging-dandisets.s3.amazonaws.com/zarr/1421096f-3b20-4027-a800-c3fee29b130a/.zarray for a zarr uploaded a year ago and thus without content-types -- browser just offers to download it. So I think we are all good as -- it works! |
5b502eb
to
b502a48
Compare
Looks great, thank you @jwodder, let's proceed |
No description provided.