Adjust Neurosift external URLs for v2 of Neurosift #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
requested changes
Feb 19, 2025
yarikoptic
approved these changes
Feb 19, 2025
waxlamp
approved these changes
Feb 27, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neurosift has been updated to v2, and with this update, the URL specification has changed slightly. The old URLs still work, but they redirect to the new ones. It would be best to have DANDI use the new URL scheme for the external links.
For example, for a dandiset:
old:
https://neurosift.app/?p=/dandiset&dandisetId=001335&dandisetVersion=draft
new:
https://neurosift.app/dandiset/001335?dandisetVersion=draft
And for an NWB file:
old:
https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/7d5046f1-12b5-4b88-9ccf-9e738f265652/download/&dandisetId=000409&dandisetVersion=draft
new:
https://neurosift.app/nwb?url=https://api.dandiarchive.org/api/assets/7d5046f1-12b5-4b88-9ccf-9e738f265652/download/&dandisetId=000409&dandisetVersion=draft
For an AVI file, this is not (yet) supported in v2, so we should direct this to v1 explicitly like this:
old:
https://neurosift.app?p=/avi...
new
https://v1.neurosift/avi?...
(I don't have an example for that one at my fingertips)