Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support links in the footer #2134

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Update support links in the footer #2134

merged 4 commits into from
Feb 3, 2025

Conversation

kabilar
Copy link
Member

@kabilar kabilar commented Jan 9, 2025

Hi team, it seemed a bit redundant to have two links in the footer to the repository (one to the repository landing page, and one to the repository issues page), so I suggest removing the Issues link.

@kabilar kabilar requested a review from waxlamp January 9, 2025 04:26
@waxlamp
Copy link
Member

waxlamp commented Jan 22, 2025

My inclination is to leave this as is, or to convert the issue link to a file-a-new-issue link. But I'm ok with removing it as well. I would like opinions from @satra or @yarikoptic before making a final decision.

@satra
Copy link
Member

satra commented Jan 22, 2025

the issues should stay (perhaps even be made more prominent than the footer) and we should change the issues link to the following rather than only issues in the archive repo: https://github.com/dandi/helpdesk/issues/new/choose

@kabilar
Copy link
Member Author

kabilar commented Jan 22, 2025

Sounds good. I had proposed removing it since we have a Help button in the top navigation bar.

How about the following:

Current:

Support:
- [DANDI Project Homepage](https://about.dandiarchive.org/)
- [Project GitHub](https://github.com/dandi/dandi-archive) / [Issues](https://github.com/dandi/dandi-archive/issues)

Updated proposal:

Support:
- [Send an email](mailto:[email protected])
- [File an issue](https://github.com/dandi/helpdesk/issues/new/choose)

@kabilar kabilar changed the title Update footer to remove Issues link and change hyperlink text Update support links in the footer Feb 3, 2025
@kabilar
Copy link
Member Author

kabilar commented Feb 3, 2025

Hi @waxlamp, following up from today's discussion, I have updated this pull request based on the above proposal.

@kabilar
Copy link
Member Author

kabilar commented Feb 3, 2025

Not sure why, but the netlify preview build failed:

...
10:58:14 AM: build.command from netlify.toml                               
10:58:14 AM: ────────────────────────────────────────────────────────────────
10:58:14 AM: ​
10:58:14 AM: $ git fetch --tags && yarn run build
10:58:14 AM: yarn run v1.22.10
10:58:14 AM: $ vite build
10:58:15 AM: vite v3.2.7 building for production...
10:58:15 AM: transforming...
10:58:16 AM: ✓ 197 modules transformed.
10:58:16 AM: [vite:vue2] Unexpected token, expected "," (1:2215)
10:58:16 AM: file: /opt/build/repo/web/src/components/DandiFooter.vue:1:2215
10:58:16 AM: error during build:
10:58:16 AM: SyntaxError: Unexpected token, expected "," (1:2215)
10:58:16 AM:     at constructor (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:356:19)
10:58:16 AM:     at Parser.raise (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:3223:19)
10:58:16 AM:     at Parser.unexpected (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:3253:16)
10:58:16 AM:     at Parser.expect (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:3590:28)
10:58:16 AM:     at Parser.parseObjectLike (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:11655:14)
10:58:16 AM:     at Parser.parseExprAtom (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:11160:23)
10:58:16 AM:     at Parser.parseExprSubscripts (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:10862:23)
10:58:16 AM:     at Parser.parseUpdate (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:10845:21)
10:58:16 AM:     at Parser.parseMaybeUnary (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:10821:23)
10:58:16 AM:     at Parser.parseMaybeUnaryOrPrivate (/opt/build/repo/web/node_modules/@babel/parser/lib/index.js:10659:61)
10:58:16 AM: error Command failed with exit code 1. (https://ntl.fyi/exit-code-1)
10:58:16 AM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
10:58:16 AM: ​
10:58:16 AM: "build.command" failed                                        
10:58:16 AM: ────────────────────────────────────────────────────────────────
10:58:16 AM: ​
10:58:16 AM:   Error message
10:58:16 AM:   Command failed with exit code 1: git fetch --tags && yarn run build (https://ntl.fyi/exit-code-1)
10:58:16 AM: ​
10:58:16 AM:   Error location
10:58:16 AM:   In build.command from netlify.toml:
10:58:16 AM:   git fetch --tags && yarn run build
10:58:16 AM: ​
10:58:16 AM:   Resolved config
10:58:16 AM:   build:
10:58:16 AM:     base: /opt/build/repo/web
10:58:16 AM:     command: git fetch --tags && yarn run build
10:58:16 AM:     commandOrigin: config
10:58:16 AM:     environment:
10:58:16 AM:       - REVIEW_ID
10:58:16 AM:       - NODE_VERSION
10:58:16 AM:       - VITE_APP_OAUTH_API_ROOT
10:58:16 AM:       - VITE_APP_OAUTH_CLIENT_ID
10:58:16 AM:       - VITE_APP_DANDI_API_ROOT
10:58:16 AM:       - VITE_APP_SENTRY_DSN
10:58:16 AM:       - VITE_APP_SENTRY_ENVIRONMENT
10:58:16 AM:     ignore: 'false'
10:58:16 AM:     publish: /opt/build/repo/web/dist
10:58:16 AM:     publishOrigin: config
10:58:16 AM:   plugins:
10:58:16 AM:     - inputs: {}
10:58:16 AM:       origin: config
10:58:16 AM:       package: /netlify/plugins/server-info-build
10:58:16 AM:   redirects:
10:58:16 AM:     - from: /handbook
10:58:16 AM:       to: https://docs.dandiarchive.org/
10:58:17 AM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
10:58:17 AM:     - from: /*
      status: 200
      to: /index.html
  redirectsOrigin: config
10:58:17 AM: Build failed due to a user error: Build script returned non-zero exit code: 2
10:58:17 AM: Failing build: Failed to build site
10:58:17 AM: Finished processing build request in 36.203s

This was causing a parse error on `mailto:[email protected]` since
the v-bind directive causes the value to be interpreted as JavaScript.
In this case, the `mailto:` part looks like a label, following by
something that is not valid JS.

Since the value we want here is static, we don't need to use v-bind in
any case.
@waxlamp
Copy link
Member

waxlamp commented Feb 3, 2025

Not sure why, but the netlify preview build failed:

See the commit message for the fix/explanation.

@waxlamp waxlamp added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 3, 2025
@waxlamp waxlamp merged commit b753a87 into dandi:master Feb 3, 2025
4 checks passed
@dandibot
Copy link
Member

dandibot commented Feb 3, 2025

🚀 PR was released in v0.4.15 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants