-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support links in the footer #2134
Conversation
My inclination is to leave this as is, or to convert the issue link to a file-a-new-issue link. But I'm ok with removing it as well. I would like opinions from @satra or @yarikoptic before making a final decision. |
the issues should stay (perhaps even be made more prominent than the footer) and we should change the issues link to the following rather than only issues in the archive repo: https://github.com/dandi/helpdesk/issues/new/choose |
Sounds good. I had proposed removing it since we have a How about the following: Current:
Updated proposal:
|
Issues
link and change hyperlink text
Hi @waxlamp, following up from today's discussion, I have updated this pull request based on the above proposal. |
Not sure why, but the netlify preview build failed:
|
This was causing a parse error on `mailto:[email protected]` since the v-bind directive causes the value to be interpreted as JavaScript. In this case, the `mailto:` part looks like a label, following by something that is not valid JS. Since the value we want here is static, we don't need to use v-bind in any case.
See the commit message for the fix/explanation. |
🚀 PR was released in |
Hi team, it seemed a bit redundant to have two links in the footer to the repository (one to the repository landing page, and one to the repository issues page), so I suggest removing the
Issues
link.