Skip to content

Conversation

@kernelkind
Copy link
Member

closes #867

@kernelkind
Copy link
Member Author

video demonstration: https://v.nostr.build/zchMG2hmEPeW3yDY.mp4

@kernelkind kernelkind requested a review from jb55 June 18, 2025 20:08
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few observations before I jump into the code:

  • Threads should be chronological, not reverse chronological (like timelines)

  • Whats the pink dot?

  • Context menu actions inside a quote repost/note preview seems broken (like copy text)

@jb55
Copy link
Contributor

jb55 commented Jun 19, 2025

threads are not immediately populated, i have to open it, leave, and open it again to see the notes

@jb55
Copy link
Contributor

jb55 commented Jun 19, 2025

Back nav doesn't retain previous scroll position.

When you nav and go back within a thread, the scroll position gets reset to the top

@jb55
Copy link
Contributor

jb55 commented Jun 19, 2025

my logs seem to be getting spammed with:

2025-06-19T16:54:26.861545Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.866215Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.922482Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.926835Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.950209Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.954500Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.958645Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.962629Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:26.966685Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.022587Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.027366Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.051035Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.055357Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.059395Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.063653Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.067709Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.122650Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.127800Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.152907Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.157319Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub
2025-06-19T16:54:27.161731Z ERROR notedeck_columns::timeline::thread: Was expecting to find local sub

to reproduce:

  1. Open thread
  2. Click a reply
  3. Drag action to return to previous route

@kernelkind
Copy link
Member Author

Addressed the following:

  • threads are not immediately populated, i have to open it, leave, and open it again to see the notes
  • back drag bug
  • Threads should be chronological, not reverse chronological (like timelines)
  • Context menu actions inside a quote repost/note preview seems broken (like copy text)
  • make selected note not routable
  • need some way of going back only one route, not whole overlay
  • Back nav doesn't retain previous scroll position. When you nav and go back within a thread, the scroll position gets reset to the top

@kernelkind kernelkind requested a review from jb55 June 22, 2025 21:08
@jb55 jb55 merged commit 7ba81d0 into damus-io:master Jun 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ThreadView should mimic iOS reply chain behavior

2 participants