-
Notifications
You must be signed in to change notification settings - Fork 49
Threads upgrade #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads upgrade #900
Conversation
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
|
video demonstration: https://v.nostr.build/zchMG2hmEPeW3yDY.mp4 |
jb55
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few observations before I jump into the code:
-
Threads should be chronological, not reverse chronological (like timelines)
-
Whats the pink dot?
-
Context menu actions inside a quote repost/note preview seems broken (like copy text)
|
threads are not immediately populated, i have to open it, leave, and open it again to see the notes |
|
Back nav doesn't retain previous scroll position. When you nav and go back within a thread, the scroll position gets reset to the top |
|
my logs seem to be getting spammed with: to reproduce:
|
remove when damus-io/egui-nav merges Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
|
Addressed the following:
|
closes #867