235 follow unfollow user #799
Conversation
Signed-off-by: Jakub Gladysz <[email protected]>
Signed-off-by: Jakub Gladysz <[email protected]>
|
hey guys, while doing this I see such errors when the note is submitted:
I was thinking I might have a look, but since the follow/unfollow works (I am checking on my testing account) I thought it could be something unrelated to this feature, but I don't know. I thought I better ask you first, maybe you have seen this before and have some idea! |
|
taking a look at this now! |
|
there are lots of issues with this. it looks like the kind3 creation is destructive which is not good. it shouldn't be removing existing tags. what we probably want is an API for creating a note builder from an existing note. I will iterate on this. |
|
rebased and I'm iterating on this on the |
|
alright! Good point with Unknown variant. About removing the tags, now I see it, I was following the spec and didn't even think there could be other tags in kind 3 that we might want to copy. I will follow that branch to learn something from it! I will close this PR then |
Closes #235