security fix

damianofalcioni · Apr 4, 2018 · 75941ce · 75941ce
1 parent 5186997
commit 75941ce
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ipb.php b/ipb.php
@@ -1099,8 +1099,10 @@ function getallheaders() {
  } else {
  $reportJson = json_decode(file_get_contents($reportFolderFull.'/'.$json->trackUUID.'.json'));
  if($reportJson->configUUID != $json->uuid){
- $reportJson->configUUID = $json->uuid;
- file_put_contents($reportFolderFull.'/'.$json->trackUUID.'.json', json_encode($reportJson));
+ throw new Exception('trackUUID already in use by another configuration.');
+ //SECURITY FIX: allowing the uuid update into the tracking file (next two lines) give the possibility for a tracked user to save a new configuration using its traking uuid, stealing its traking file to the original configuration
+ //$reportJson->configUUID = $json->uuid;
+ //file_put_contents($reportFolderFull.'/'.$json->trackUUID.'.json', json_encode($reportJson));
  }
  }
  file_put_contents($configFolderFull.'/'.$json->uuid.'.json', $jsonString);