fix: theme flicker in funnel #4538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
requested review from
capJavert,
ilasw,
nensidosari,
omBratteng,
rebelchris and
sshanzel
idoshamun
approved these changes
May 29, 2025
rebelchris
approved these changes
May 29, 2025
Contributor
rebelchris
left a comment
rebelchris
left a comment
There was a problem hiding this comment.
I remember we had such issue on the main pages as well, and fixing it caused some other edge-cases.
But code wise this looks good to me :)
sshanzel
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix theme flicker in the funnel as reported by @idoshamun here
Issue seems to have been caused by waiting for
isAuthReadybefore setting the correct theme. This became very visible when using light theme because the default theme is dark.Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-904
Preview domain
https://mi-904.preview.app.daily.dev