-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Clean up the docs snippets snapshots tests #27996
base: master
Are you sure you want to change the base?
[components] Clean up the docs snippets snapshots tests #27996
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 | key: "target/main/{{ node.name }} | ||
| ^ Unable to parse YAML: while scanning a quoted scalar, found unexpected end of stream | ||
| ^ Unable to parse YAML: while scanning a quoted scalar, found unexpected end of stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caret (^
) error indicator appears to be misaligned - it should point to position 44 where the unclosed quote occurs in the line key: "target/main/{{ node.name }}
. Proper alignment helps developers quickly identify the exact location of YAML parsing errors.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It points to the right place now and the wrong place before
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-1saf6uvcn-elementl.vercel.app Direct link to changed pages: |
Summary and Motivation
Clean up the docs snippet CLI snapshot tests:
dedent
Test Plan
existing test suite