Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dagster-dg to make install dev script #27957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gibsondan
Copy link
Member

@gibsondan gibsondan commented Feb 20, 2025

Summary & Motivation

Include dagster-dg in the dagster local dev environment.

How I Tested These Changes

Run make dev command locally

Changelog

NOCHANGELOG

Run make dev command locally

NOCHANGELOG
@gibsondan gibsondan requested a review from smackesey February 20, 2025 19:58
@gibsondan gibsondan changed the title Add dagster-db to make install dev script Add dagster-dg to make install dev script Feb 20, 2025
@gibsondan gibsondan requested a review from benpankow February 20, 2025 19:58
Copy link
Collaborator

@smackesey smackesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think we should avoid this because dg is supposed to run in an isolated environment and may hard-pin dependencies (it already does with typer). Preferred way to dev with dg is uv tool install -e /path/to/dagster-dg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants