[dagster-dg] Add separate command to generate JSON schema for code location #27896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benpankow
requested review from
smackesey,
gibsondan,
OwenKephart and
schrockn
benpankow
commented
Feb 18, 2025
| @@ -30,12 +31,32 @@ def test_configure_editor(editor: str) -> None: | |||
|
|
|||
| assert out.exit_code == 0 | |||
|
|
|||
| sample_project_vscode_path = Path.cwd() / ".vscode" | |||
| assert (sample_project_vscode_path / "schema.json").exists() | |||
| sample_project_dg_path = Path.cwd() / ".dg" | |||
There was a problem hiding this comment.
Changed this to .dg folder instead of .vscode, open to other suggestions though. We'll likely want a "place to store dg state/metadata" in code locations at some point for other commands, I'd reckon?
schrockn
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a command to generate a JSON schema for a given code location. Drops the schema in the location referenced by the VS Code extension, so this can be used to update the schema without the other rigamarole involved with that command.
When #27863 lands, I intend to add a
--watchflag to this command as well, so you can live-update the schema if the set of components changes.Test Plan
Brief test, the underlying
dagster-componentsCLI tests correctness.