Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stale status filtering capability to the asset catalog UI #27886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axellpadilla
Copy link
Contributor

Summary & Motivation

Adds stale status filtering capability to the asset catalog UI, allowing users to filter assets based on their stale status (Fresh, Stale, Missing). This improves asset monitoring and management by making it easier to identify assets that need attention.

Changes

  • Add stale status to asset GraphQL fragment
  • Implement new useStaleStatusFilter hook with status indicators
  • Update useAssetDefinitionFilterState to handle stale status filters
  • Add stale status filter to asset catalog filtering UI
  • Add test coverage for stale status filtering
  • Update data version logic to handle partitioned assets without specified partitions
  • Add test for stale status behavior with partitioned assets

Test Plan

  • Added unit tests for stale status filtering functionality
  • Added test cases for partitioned asset stale status behavior
  • Existing test coverage maintained and expanded

Related

Builds on existing asset filtering infrastructure and stale status tracking capabilities.
Related to issue #27276 but doesn't really cover it, the issue request is about asset status case (Failed, Materialized, Etc.) but It was very difficult to add it, maybe the logic for status cases should be passed to the python resolver server instead of graphQL to reuse it on filters.

How I Tested These Changes

  • Added test + UI exploring on example repo

Changelog

Added stale status filter on asset catalog

Adds stale status filtering capability to the asset catalog UI, allowing users to filter assets based on their stale status (Fresh, Stale, Missing). This improves asset monitoring and management by making it easier to identify assets that need attention.

## Changes
- Add stale status to asset GraphQL fragment
- Implement new `useStaleStatusFilter` hook with status indicators
- Update `useAssetDefinitionFilterState` to handle stale status filters
- Add stale status filter to asset catalog filtering UI
- Add test coverage for stale status filtering
- Update data version logic to handle partitioned assets without specified partitions
- Add test for stale status behavior with partitioned assets

## Test Plan
- Added unit tests for stale status filtering functionality
- Added test cases for partitioned asset stale status behavior
- Existing test coverage maintained and expanded

## Related
Builds on existing asset filtering infrastructure and stale status tracking capabilities.
Related to issue dagster-io#27276 but doesn't really cover it, the issue request is about asset status case (Failed, Materialized, Etc.) but It was very difficult to add it, maybe the logic for status cases should be passed to the python resolver server instead of graphQL to reuse it on filters.

## How I Tested These Changes
- Added test + UI exploring on example repo

## Changelog
> Added stale status filter on asset catalog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant