Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single code server #26818

Draft
wants to merge 1 commit into
base: dpeng817/use_code_server_start
Choose a base branch
from

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Jan 3, 2025

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

dpeng817 commented Jan 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think I put this on sean's original PR too - the main downside I see after this change is that if the proxy server process crashes, there is nothing that will detect that and restart it now. Before, if that happened, you could reload things from the webserver UI, and the daemon was restarting every 60 seconds anyway.

I'm not sure if that is a blocking concern or not, but I do know that there are some people who use 'dagster dev' in a non dev context, for better or worse, and that change in behavior could affect them. One possibility would be to make this new thing opt in or opt out in some fashion. Another would be to add something that monitors the proxy server process and restarts it automatically on the same port if that is detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants