[embedded-elt][sling] Correctly get an object_key when a stream has an empty config #26797
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasn't sure about the best way to add a failing configuration as a test, so submitted without the test for now. |
…n empty config Fixes dagster-io#25515 and dagster-io#25925
Cogito
force-pushed
the
sling_empty_stream_config
branch
from
2b94628 to
2182850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This fixes an issue where Sling materialisations fail if a stream has an empty config.
A fix for #25515 and #25925
Original code by @Westm7
How I Tested These Changes
I had a failing config, which no longer fails after this change.