[ui] Add Automation History to asset checks #26766
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hellendag
force-pushed
the
dish/automation-changes
branch
from
a486dcf to
8654307
Compare
hellendag
force-pushed
the
dish/automation-asset-checks
branch
from
e5e9619 to
4881dac
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 7efdf3f. |
hellendag
force-pushed
the
dish/automation-changes
branch
from
8654307 to
958bf49
Compare
hellendag
force-pushed
the
dish/automation-asset-checks
branch
from
4881dac to
f53b43c
Compare
hellendag
force-pushed
the
dish/automation-asset-checks
branch
from
f53b43c to
f14a12b
Compare
js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/AssetCheckAutomationList.tsx
Outdated
Show resolved
Hide resolved
hellendag
force-pushed
the
dish/automation-changes
branch
from
958bf49 to
a56285f
Compare
hellendag
force-pushed
the
dish/automation-asset-checks
branch
2 times, most recently
from
29625bb to
cc60096
Compare
| > | ||
| <CursorHistoryControls {...paginationProps} style={{marginTop: 0}} /> | ||
| </Box> | ||
| <EvaluationList |
There was a problem hiding this comment.
It seems like <EvaluationList /> was already in the codebase, but not in use? Was thinking the useAssetCheckEvaluationsQueryResult hook could be used elsewhere but maybe this is the only spot!
There was a problem hiding this comment.
I built it using Storybook, and I'm adding live callsites in this PR stack.
There is a similar (but different) hook for querying evaluations on assets instead of asset checks.
hellendag
changed the base branch from
dish/automation-changes
to
graphite-base/26766
hellendag
force-pushed
the
dish/automation-asset-checks
branch
from
cc60096 to
7efdf3f
Compare
Summary & Motivation
For asset checks that use automation conditions, show an "Automation history" tab with the list of relevant evaluations, much like the Automations tab on assets.
With automation condition:
Without automation condition, hovering on tab:
How I Tested These Changes
Load app with sample repo provided by @OwenKephart, enable automation sensor. Navigate to asset checks, verify that they render correctly, and that the evaluation dialog renders properly.
Changelog
[ui] Add Automation history to asset checks.