Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-azure] delete blobs after test in integration tests #26758

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Dec 30, 2024

Summary & Motivation

This PR adds a step to delete all blobs created by the integration tests.

Previously they were just building up.

How I Tested These Changes

Existing tests still pass

Copy link
Contributor Author

dpeng817 commented Dec 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dpeng817 dpeng817 requested a review from mlarose December 30, 2024 17:13
@dpeng817 dpeng817 marked this pull request as ready for review December 30, 2024 17:13
Copy link
Contributor

@mlarose mlarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, provided the tests are fixed

@dpeng817 dpeng817 force-pushed the dpeng817/complogmngr-delete-blobs branch from a4f8c2e to 02f06c7 Compare December 30, 2024 21:52
@dpeng817 dpeng817 merged commit 942e7a0 into master Dec 30, 2024
1 check passed
@dpeng817 dpeng817 deleted the dpeng817/complogmngr-delete-blobs branch December 30, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants