Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] AssetsDefinition specs #26681

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Any, Dict, Iterable, Optional, Sequence, Union, cast

from dagster import _check as check
from dagster._annotations import experimental
from dagster._annotations import beta
from dagster._core.definitions.asset_check_factories.utils import (
DEADLINE_CRON_PARAM_KEY,
DEFAULT_FRESHNESS_SEVERITY,
Expand Down Expand Up @@ -40,7 +40,7 @@
)


@experimental
@beta
def build_last_update_freshness_checks(
*,
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Iterator, Optional, Sequence, Tuple, Union, cast

from dagster import _check as check
from dagster._annotations import experimental
from dagster._annotations import beta
from dagster._core.definitions.asset_check_factories.utils import (
FRESH_UNTIL_METADATA_KEY,
ensure_no_duplicate_asset_checks,
Expand Down Expand Up @@ -33,7 +33,7 @@
"""


@experimental
@beta
def build_sensor_for_freshness_checks(
*,
freshness_checks: Sequence[AssetChecksDefinition],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import Any, Dict, Iterable, Sequence, Union

from dagster import _check as check
from dagster._annotations import experimental
from dagster._annotations import beta
from dagster._core.definitions.asset_check_factories.utils import (
DEADLINE_CRON_PARAM_KEY,
DEFAULT_FRESHNESS_SEVERITY,
Expand Down Expand Up @@ -37,7 +37,7 @@
)


@experimental
@beta
def build_time_partition_freshness_checks(
*,
assets: Sequence[Union[SourceAsset, CoercibleToAssetKey, AssetsDefinition]],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Optional, Sequence, Tuple, Union, cast

import dagster._check as check
from dagster._annotations import experimental
from dagster._annotations import beta
from dagster._core.definitions.asset_check_factories.utils import (
assets_to_keys,
build_multi_asset_check,
Expand All @@ -21,7 +21,7 @@
from dagster._core.instance import DagsterInstance


@experimental
@beta
def build_metadata_bounds_checks(
*,
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from pydantic import BaseModel

from dagster._annotations import experimental
from dagster._annotations import beta
from dagster._core.definitions.asset_check_factories.utils import build_multi_asset_check
from dagster._core.definitions.asset_check_spec import (
AssetCheckKey,
Expand All @@ -17,7 +17,7 @@
from dagster._core.instance import DagsterInstance


@experimental
@beta
def build_column_schema_change_checks(
*,
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],
Expand Down
1 change: 0 additions & 1 deletion python_modules/dagster/dagster/_core/definitions/assets.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ class AssetsDefinition(ResourceAddable, IHasInternalInit):
_specs_by_key: Mapping[AssetKey, AssetSpec]
_computation: Optional[AssetGraphComputation]

@experimental_param(param="specs")
@experimental_param(param="execution_type")
def __init__(
self,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Sequence

from dagster import _check as check
from dagster._annotations import deprecated, experimental
from dagster._annotations import deprecated
from dagster._core.definitions.asset_spec import (
SYSTEM_METADATA_KEY_AUTO_OBSERVE_INTERVAL_MINUTES,
SYSTEM_METADATA_KEY_IO_MANAGER_KEY,
Expand All @@ -23,7 +23,6 @@ def external_asset_from_spec(spec: AssetSpec) -> AssetsDefinition:


@deprecated(breaking_version="1.9.0", additional_warn_text="Directly use the AssetSpecs instead.")
@experimental
def external_assets_from_specs(specs: Sequence[AssetSpec]) -> List[AssetsDefinition]:
"""Create an external assets definition from a sequence of asset specs.

Expand Down
5 changes: 2 additions & 3 deletions python_modules/dagster/dagster/_core/definitions/input.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
)

import dagster._check as check
from dagster._annotations import PublicAttr, deprecated_param, experimental_param
from dagster._annotations import PublicAttr, deprecated_param, superseded
from dagster._core.definitions.events import AssetKey
from dagster._core.definitions.inference import InferredInputProps
from dagster._core.definitions.metadata import (
Expand Down Expand Up @@ -59,8 +59,7 @@ def _check_default_value(input_name: str, dagster_type: DagsterType, default_val
return default_value # type: ignore # (pyright bug)


@experimental_param(param="asset_key")
@experimental_param(param="asset_partitions")
@superseded(additional_warn_text="Use `In` instead", emit_runtime_warning=False)
class InputDefinition:
"""Defines an argument to an op's compute function.

Expand Down