Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Add SlingReplicationCollection component #26650

Open
wants to merge 1 commit into
base: 12-31-_components_resolver_-_renderer
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

In practice, it's more likely for a single directory to contain many individual sling replications. This adds a component to handle that.

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Dec 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@OwenKephart OwenKephart force-pushed the 12-20-_components_remove_automationconditionmodel_in_favor_of_raw_python_object branch from cf4029f to a5770fd Compare December 20, 2024 20:55
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from cf8491d to eb2ae9f Compare December 20, 2024 20:55
@OwenKephart OwenKephart force-pushed the 12-20-_components_remove_automationconditionmodel_in_favor_of_raw_python_object branch from a5770fd to 2b0ff0d Compare December 23, 2024 20:48
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from eb2ae9f to 24a1099 Compare December 23, 2024 20:48
@OwenKephart OwenKephart requested a review from schrockn December 23, 2024 20:50
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just consolidate the "N replication" case to a single component and eliminate the old one?

@OwenKephart OwenKephart force-pushed the 12-20-_components_remove_automationconditionmodel_in_favor_of_raw_python_object branch from 2b0ff0d to 5fa066b Compare December 23, 2024 22:05
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from 24a1099 to aba016d Compare December 23, 2024 22:05
@OwenKephart OwenKephart force-pushed the 12-20-_components_remove_automationconditionmodel_in_favor_of_raw_python_object branch from 5fa066b to bf1de3b Compare December 30, 2024 15:41
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from aba016d to 0749655 Compare December 30, 2024 15:41
@OwenKephart OwenKephart force-pushed the 12-20-_components_remove_automationconditionmodel_in_favor_of_raw_python_object branch from bf1de3b to 3fb0a0b Compare December 30, 2024 22:37
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from 0749655 to e341f16 Compare December 30, 2024 22:37
@OwenKephart OwenKephart changed the base branch from 12-20-_components_remove_automationconditionmodel_in_favor_of_raw_python_object to 12-30-_components_replace_requiredscope_with_renderedmodel December 30, 2024 22:37
@OwenKephart OwenKephart changed the base branch from 12-30-_components_replace_requiredscope_with_renderedmodel to graphite-base/26650 December 31, 2024 16:11
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from e341f16 to 3c84475 Compare December 31, 2024 16:14
@OwenKephart OwenKephart changed the base branch from graphite-base/26650 to master December 31, 2024 16:14
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch 2 times, most recently from fc1d597 to ac8c746 Compare December 31, 2024 17:49
@OwenKephart OwenKephart changed the base branch from master to 12-31-_components_use_assetattributesmodel_instead_of_dbttranslatorparams December 31, 2024 17:49
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from ac8c746 to 3a92f4f Compare December 31, 2024 17:54
@OwenKephart OwenKephart changed the base branch from 12-31-_components_use_assetattributesmodel_instead_of_dbttranslatorparams to 12-31-_components_resolver_-_renderer December 31, 2024 17:54
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from 3a92f4f to 990e970 Compare December 31, 2024 18:16
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:16
Copy link
Contributor Author

done!

@OwenKephart OwenKephart force-pushed the 12-31-_components_resolver_-_renderer branch from 59cb5ae to d46d16c Compare December 31, 2024 18:18
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from 990e970 to f97cd3c Compare December 31, 2024 18:19
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from f97cd3c to d544be9 Compare December 31, 2024 18:38
@OwenKephart OwenKephart force-pushed the 12-31-_components_resolver_-_renderer branch from d46d16c to 619b06e Compare December 31, 2024 20:15
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from d544be9 to 1bff946 Compare December 31, 2024 20:15
@OwenKephart OwenKephart force-pushed the 12-31-_components_resolver_-_renderer branch from 619b06e to 8ccb2f0 Compare January 7, 2025 01:05
@OwenKephart OwenKephart force-pushed the 12-19-_components_add_slingreplicationcollection_component branch from 1bff946 to 69250b9 Compare January 7, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants