Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[du] remove fastparquet dependency [DEV-414] #23403

Merged

Conversation

PedramNavid
Copy link
Contributor

@PedramNavid PedramNavid commented Aug 4, 2024

Summary & Motivation

fastparquet requires admin privileges on PCs, and it isn't required for this course.

How I Tested These Changes

@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label Aug 4, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 August 4, 2024 03:01
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @PedramNavid and the rest of your teammates on Graphite Graphite

@PedramNavid PedramNavid requested a review from cmpadden August 4, 2024 03:02
Copy link

github-actions bot commented Aug 4, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-q4k3ouzs1-elementl.vercel.app
https://pdrm-08-03--du-remove-fastparquet-dependency-dev-414.dagster.dagster-docs.io

Direct link to changed pages:

@cmpadden
Copy link
Contributor

cmpadden commented Aug 7, 2024

Thanks @PedramNavid - I've also removed it from project-dagster-university.

dagster-io/project-dagster-university#33

I've created a new venv without fastparquet and confirmed that assets materialized as expected.
image

Copy link
Contributor Author

PedramNavid commented Aug 7, 2024

Merge activity

@PedramNavid PedramNavid merged commit 5567671 into master Aug 7, 2024
2 checks passed
@PedramNavid PedramNavid deleted the pdrm/08-03-_du_remove_fastparquet_dependency_dev-414_ branch August 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants