Skip to content

Commit

Permalink
Show asset selection for hidden asset jobs (#28004)
Browse files Browse the repository at this point in the history
## Summary & Motivation

As titled

## How I Tested These Changes

👀 

## Changelog

[ui] Fixed an issue where certain jobs weren't showing the assets they
targeted.
  • Loading branch information
salazarm authored Feb 23, 2025
1 parent b417349 commit ac1e66f
Showing 1 changed file with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ export const RunAssetTags = (props: {run: RunFragment}) => {
});

const assetKeys = useMemo(() => {
const {data, loading} = queryResult;
if (loading || !data || data.pipelineRunOrError.__typename !== 'Run') {
return null;
const {data} = queryResult;
let keys = null;
if (data?.pipelineRunOrError.__typename === 'Run') {
keys = data.pipelineRunOrError.assets.map((a) => a.key);
}

return skip ? assetKeysForRun(run) : data.pipelineRunOrError.assets.map((a) => a.key);
return skip ? assetKeysForRun(run) : keys;
}, [queryResult, run, skip]);

return <AssetKeyTagCollection useTags assetKeys={assetKeys} />;
Expand Down

1 comment on commit ac1e66f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-dtynzaoo9-elementl.vercel.app

Built with commit ac1e66f.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.