Support markers at start and midpoint of edges (resolving conflicts in #316) #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strong +1! |
|
+1 |
|
Can you help review this PR and point out potential risks for performance or compatibility? |
lutzroeder
force-pushed
the
master
branch
2 times, most recently
from
d380990
to
3e26aa2
Compare
|
I think instead of |
|
This would be great to have. |
|
I ported the project to es6 and I accept contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just copied all changes from #316, then had the conflicts resolved.
Hope this feature can be available in release as early as possible.