feat(sdk/dotnet): rework on query builder #7208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
But still out of the solution since it under construction. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
wingyplus
commented
Apr 26, 2024
| { | ||
| private readonly HttpClient _httpClient; | ||
|
|
||
| public GraphQLClient() : this(Environment.GetEnvironmentVariable("DAGGER_SESSION_PORT")!, Environment.GetEnvironmentVariable("DAGGER_SESSION_TOKEN")!) |
There was a problem hiding this comment.
I think our first priority is to get it support module. So I think it's ok for now to support only run under dagger run.
wingyplus
commented
Apr 26, 2024
|
|
||
| public class Dagger | ||
| { | ||
| } |
There was a problem hiding this comment.
I'll leave it empty class for now until we make codegen work.
wingyplus
commented
Apr 26, 2024
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
|
@wingyplus This is funny coincidence. I just forked and started looking at code generation the other day: https://github.com/MikaelElkiaer/dagger/tree/feat/sdk-dotnet-codegen/sdk/dotnet |
|
@MikaelElkiaer yeah, I just start exploring the codegen yesterday too. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR try to modernize DotNet SDK by do the following:
.editorconfigto makedotnet formatworks.QueryBuilderclass and port the logic from Go to it. Mostly feature is covered I guess.DaggerSDKtoDagger.SDK.DaggerSDKCodegenout of the solution. We will tackle next after this PR. :)