Improve releasing during v0.11.2 #7205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhard
reviewed
Apr 26, 2024
There was a problem hiding this comment.
This looks good, thank you @jedevc for sailing another release ⛵️
We will no longer bump the legacy CI runners. All that infra is scheduled to be deleted at the end of this week. There are two potential alternatives:
- Migrate to new ci runners #7082
- CI: Try running Engine & CLI workflow in larger GitHub runners #7197
It doesn't matter which direction we end up taking as long as we stop using the first generation of our Dagger Runners.
Before we merge this, I want to add the following changes:
- Bump the Helm chart default version to
v0.11.2 - Capture it in
RELEASING.md
Before I do that though, I want to rebase & merge this PR first:
Almost there 💪
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
gerhard
force-pushed
the
improve-releasing-during-v0.11.2
branch
from
3c76ca2
to
3c9eb4e
Compare
Also prepare the Helm chart for release right after this gets merged. Also run `go mod tidy` after rebasing. Signed-off-by: Gerhard Lazu <[email protected]>
gerhard
force-pushed
the
improve-releasing-during-v0.11.2
branch
from
3c9eb4e
to
20d0378
Compare
|
This is now finally there! Merging so that we I can focus on this one next: This weekend is perfect for this type of maintenance work 🧑🔧 |
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 8, 2024
* chore: update internal tooling to v0.11.2 Signed-off-by: Justin Chadwell <[email protected]> * docs: update docs to refer to newest v0.11.2 release Signed-off-by: Justin Chadwell <[email protected]> * ci: update to install dagger cli v0.11.2 Signed-off-by: Justin Chadwell <[email protected]> * chore: update RELEASING guide Signed-off-by: Justin Chadwell <[email protected]> * chore: Add Helm releasing instructions to RELEASING.md Also prepare the Helm chart for release right after this gets merged. Also run `go mod tidy` after rebasing. Signed-off-by: Gerhard Lazu <[email protected]> --------- Signed-off-by: Justin Chadwell <[email protected]> Signed-off-by: Gerhard Lazu <[email protected]> Co-authored-by: Gerhard Lazu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.