Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add git to go sdk #7191

Merged
merged 1 commit into from May 10, 2024
Merged

chore: add git to go sdk #7191

merged 1 commit into from May 10, 2024

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Apr 25, 2024

Attempting to revive #6248 - see discussion in discord here.

@jedevc
Copy link
Member Author

jedevc commented Apr 25, 2024

Hmmm, it looks like whatever underlying issue was happening in #6248 is gone now 🎉

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Signed-off-by: Justin Chadwell <[email protected]>
Copy link
Contributor

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised we got this far without it tbh. Guess we've been relying on the Go caching/proxy layer?

@jedevc
Copy link
Member Author

jedevc commented May 10, 2024

Yup exactly 😆 Honestly, it's also a bit weird the the official golang images don't include a git binary, but, oh well, it's easy enough to install.

@jedevc jedevc merged commit e678cdd into dagger:main May 10, 2024
63 checks passed
@jedevc jedevc deleted the add-git-to-go-sdk branch May 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants