feat: propagate DAGGER_ENGINE_* environ variables on engine to pipelines #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne containers Signed-off-by: haoqixu <[email protected]>
haoqixu
force-pushed
the
feat-env-var-propagation
branch
from
bed4277
to
01d6584
Compare
Signed-off-by: haoqixu <[email protected]>
haoqixu
force-pushed
the
feat-env-var-propagation
branch
from
19e2adc
to
b8a9565
Compare
|
@haoqixu thanks for the PR! We need to go with a slightly different approach (we don't want all of these env vars to be set in every container, need to be more selective) and add integ test coverage for all this. I missed this and started working on all of it already here: #7255 So while I appreciate this I'm gonna close this for now; the support is coming very soon though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the shim to propagate
DAGGER_ENGINE_*environ on the engine to pipeline containers. Part of #6599