chore: enable unparam linter #7174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
commented
Apr 24, 2024
dagql/objects.go
Outdated
There was a problem hiding this comment.
While I was in the area, I also fixed up some of the incorrect doc comments here 🎉
jedevc
force-pushed
the
little-lint-fixes
branch
from
25a1da8 to
33e0dae
Compare
sipsma
approved these changes
May 2, 2024
Signed-off-by: Justin Chadwell <[email protected]>
And also enable a linter to catch these in the future. `unparam` seems to be optimized more heavily to avoid false positives, and is significantly better at not bringing up weird interface cases that revive seems to love. Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially inspired by moby/buildkit#4828 upstream.
Unused parameters can sometimes indicate weird issues, at the very least that are a bit of a code smell (additionally, gopls in vscode loves to flag these, which is the main reason I wanted to clear them up lol).
Thankfully, none of these are significant, there are no hiding bugs, it's just a little bit of a tidy up.
unparamdefinitely seems to be optimized for less "noise", and doesn't pick up on every unused parameter - it seems to try and avoid finding cases where this is used in an interface/higher-order function.