Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 api: skip entrypoints by default in withExec #7136

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

helderco
Copy link
Contributor

@helderco helderco commented Apr 19, 2024

Warning

It's a breaking change for anyone currently depending on the entrypoint in withExec.
To avoid it, users can set skipEntrypoint: false today, which will preserve that same behavior after this change.1

Alternative solution to:

Flipped the default on withExec instead. Currently you need to explicitly skip the entrypoint, but with this change, you'll have to explicitly use it instead. Otherwise the entrypoint is still in the Container object, and preserved on publish.

Footnotes

  1. Albeit deprecated until a few releases down the line, so users should be encouraged to change to useEntrypoint: true when able. ↩

Copy link
Contributor

github-actions bot commented May 4, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 4, 2024
@helderco helderco removed the stale label May 6, 2024
@helderco helderco changed the title core: Skip entrypoints by default in withExec 💥 api: skip entrypoints by default in withExec May 6, 2024
@helderco helderco added the breaking change Breaking Change label May 6, 2024
@gerhard gerhard added this to the v0.12.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants