feat(config): wildcard interface name support & refactor lazybind #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
#724是个issue，不是pr |
mzz2017
reviewed
Feb 20, 2025
control/interface_manager.go
Outdated
| @@ -0,0 +1,117 @@ | |||
| package control | |||
There was a problem hiding this comment.
把这个 interface manager 组件放到 components 里？
control/interface_manager.go
Outdated
| callbacks []callbackSet | ||
| } | ||
|
|
||
| func newInterfaceManager(log *logrus.Logger, closed context.Context) *InterfaceManager { |
There was a problem hiding this comment.
按照约定，ctx 应该放到第一个参数，就叫 ctx 就好，代表生命周期。不过我建议不是传入 ctx（因为有歧义，也可能代表这个函数的生命周期），而是可以在 newXXX 函数里 context.WithCancel 并对该 struct 实现 Close() error 接口。
control/interface_manager.go
Outdated
| } | ||
|
|
||
| switch update.Header.Type { | ||
| case unix.RTM_NEWLINK: |
There was a problem hiding this comment.
根据 #729，NEWLINK 事件可能会由多种事件触发，是否要判断 UpFlag == 0?或者在 cb 函数里自己判断
这里需要测试一下用户说的 pppoe 断开重连场景
control/control_plane_core.go
Outdated
| return err | ||
| } | ||
| newlinkCallback := func(link netlink.Link) { | ||
| if link.Attrs().Name == "dae0" { |
There was a problem hiding this comment.
dae0 是否有对应的 const？能否对所有出现的 dae0 string 统一抽象出 const？
control/control_plane_core.go
Outdated
| if link.Attrs().Name == "dae0" { | ||
| return | ||
| } | ||
| c.log.Warnf("New link creation of '%v' is detected. Bind LAN program to it.", link.Attrs().Name) |
There was a problem hiding this comment.
日志应该打 Bind WAN ，包括下面也有一行日志错误。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#724
该PR抽象了lazybind的能力以便后续其他功能使用（主要是后续在routing中过滤interface需要）
该PR实现的功能与 #729 类似
此外，为wan也加入了lazybind
Checklist
Full Changelogs
Issue Reference
Closes #724
Closes #729
Test Result