-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pull/get_page API #3
Conversation
Change-Id: I2fbd448abd39cc123f483bc19963c1f7c75b8122
The two issue about freeing pointer is solved: the pointer returned by |
Sorry for my late response. I was on vacation and now I am pretty busy preparing for an upcoming exam. It might take a while until I can look into this. |
Co-authored-by: David C. <[email protected]>
Good suggestions! Fixed and request review again ❤️ |
While it would be great to have proper unit tests (for the entire library), an example that shows how this API can be used would be a really good idea (either as an example in |
@d-k-bo I'm afraid that my example/test code is not ready yet. Can we merge this pr first? |
Thanks for your contribution! |
It is now available in version 0.2.2 on crates.io. |
There are few things I'm not sure yet:
Vec::from_raw_parts
for higher performance (I encountered with panicpointer being freed was not allocated
, seems they don't use the same allocator?)std::ptr::drop_in_place
would free the memory allocated by C, should we add a dependencylibc
to uselibc::free
?examples/
ortests/
besides the readmeHi @d-k-bo, do you have time to review this PR? I wish we can have a release when this PR is merged.