Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Meson build #32

Merged
merged 5 commits into from
Jun 27, 2023
Merged

MAINT: Meson build #32

merged 5 commits into from
Jun 27, 2023

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Jun 27, 2023

Closes #31. Some issues with linking lua especially from within environments and the whole luafilesystem management via luarocks but that shouldn't be a blocker for this.

@HaoZeke HaoZeke requested a review from amritagos as a code owner June 27, 2023 01:46
HaoZeke and others added 4 commits June 27, 2023 01:50
@HaoZeke @RuhiRG
BLD: Fixup for subproject usage
0da9bbd 
Co-authored-by: Ruhila S <[email protected]>
@HaoZeke @RuhiRG
BLD,TMP: Try to fix meson lua build
2638546 
This is still buggy, for the executable, but that's OK.

Co-authored-by: Ruhila S <[email protected]>
@HaoZeke @RuhiRG
BLD: Fixup CI job
f049270 
Co-authored-by: Ruhila S <[email protected]>
@HaoZeke @RuhiRG
MAINT: Cleanup gitignore
5b45c92 
Co-authored-by: Ruhila S <[email protected]>
amritagos
amritagos approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@amritagos amritagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super eager to add a build system which doesn't currently compile the executable so no docs is alright for this PR. I can see it simplifies the library build, and the CI is green, so LGTM!

Thanks @RuhiRG and @HaoZeke.

@amritagos amritagos merged commit a371255 into main Jun 27, 2023
6 checks passed
@amritagos amritagos deleted the mesonBuild branch June 27, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amritagos amritagos amritagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAINT: Make yodaLib accessible from a meson subproject
2 participants
@HaoZeke @amritagos